[Wikidata-bugs] [Maniphest] [Commented On] T188717: Move Wikibase to using the normal mediawiki extension (quibble) jobs

[hashar]

hashar added a comment.

Ok sorry for the confusion.

Meanwhile, I have Quibble running Wikibase PHPUnit tests just fine with:

ZUUL_PROJECT=mediawiki/extensions/Wikibase quibble --run=phpunit

Thought there are 200 skipped tests for Database less tests, related to lack of CLDR/CirrusSearch/and 79 skipped ones for Database tests. Seems to be integration tests that rely on CirrusSearch/CLDR/Scribunto/Echo etc.

So maybe we can drop the old Client vs Repo jobs? They use a script in Wikibase:

build/jenkins/mw-apply-wb-settings.sh
#!/bin/bash -xe

function usage {
  echo "usage: $0 -r <repo|client> -e <true|false> -b <true|false>"
  echo "       -r specify if the settings are for repo or client"
  echo "       -b specify if the settings are for a build or not"
  exit 1
}

while getopts r:e:b: opt
do
   case $opt in
       r) REPO="$OPTARG";;
       b) BUILD=$OPTARG;;
   esac
done

if [ $BUILD = true ]; then
  echo "-b true is not supported by this script anymore."
  exit 1
fi

function apply_client_settings {
  echo "client"
  echo '$wgEnableWikibaseRepo = false;' >> LocalSettings.php
  echo '$wgEnableWikibaseClient = true;' >> LocalSettings.php
  # $wgWikimediaJenkinsCI is only set later, so need to set it here, too
  echo '$wgWikimediaJenkinsCI = true;' >> LocalSettings.php
  echo '$wmgUseWikibaseRepo = false;' >> LocalSettings.php
  echo '$wmgUseWikibaseClient = true;' >> LocalSettings.php
  echo 'require_once __DIR__ . "/extensions/Wikibase/Wikibase.php";' >> LocalSettings.php
}

function apply_repo_settings {
  echo '$wgEnableWikibaseRepo = true;' >> LocalSettings.php
  echo '$wgEnableWikibaseClient = true;' >> LocalSettings.php
  # $wgWikimediaJenkinsCI is only set later, so need to set it here, too
  echo '$wgWikimediaJenkinsCI = true;' >> LocalSettings.php
  echo '$wmgUseWikibaseRepo = true;' >> LocalSettings.php
  echo '$wmgUseWikibaseClient = true;' >> LocalSettings.php
  echo 'require_once __DIR__ . "/extensions/Wikibase/Wikibase.php";' >> LocalSettings.php
}

cd $WORKSPACE/src

if [ "$(tail -n1 LocalSettings.php)" = "?>" ]
then
  PHPTAGS=true
fi
if [ -v PHPTAGS ]
then
  echo '<?php' >> LocalSettings.php
fi

if [ "$REPO" = "repo" ]
then
  apply_repo_settings
elif [ "$REPO" = "client" ]
then
  apply_client_settings
else
  usage
fi

if [ -v PHPTAGS ]
then
  echo '?>' >> LocalSettings.php
fi

TASK DETAIL

https://phabricator.wikimedia.org/T188717

EMAIL PREFERENCES

https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: hashar
Cc: hashar, Pablo-WMDE, Addshore, WMDE-leszek, Legoktm, Aklapper, Nandana, A.S.Kochergin, God, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, Wikidata-bugs, aude, Mbch331

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs