LarsWirzenius added a comment.

If we want to set a default locale for images built by Blubber, we can set LC_ALL or LC_CTYPE. The former overrides all other locale environment variables, the latter only for character sets. The former is simpler, the latter is a smaller change to status quo. I don't know which is better.

@dduvall I'm looking at Blubber source and not sure where to add a default variable to generated Dockerfiles. Meaning, the Dockerfile should have a line like this:

ENV LC_ALL=C.UTF-8

The best I can come up with on my own is adding the following line as line 33 of config/runs.go (I think the function is called Merge):

run.Environment["LC_ALL"] = "C.UTF-8"

Is that a good way of doing it?


TASK DETAIL
https://phabricator.wikimedia.org/T210260

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: LarsWirzenius
Cc: LarsWirzenius, dduvall, hashar, akosiaris, Aklapper, Ladsgroup, Nandana, NebulousIris, Lahi, Gq86, Vacio, GoranSMilovanovic, QZanden, Gstupp, LawExplorer, _jensen, D3r1ck01, Liudvikas, notconfusing, Luke081515, thcipriani, mobrovac, Wikidata-bugs, aude, Alchimista, Addshore, Mbch331, Jay8g, greg
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to