[Wikidata-bugs] [Maniphest] [Commented On] T238575: Wikibase test builds failing with “ERROR: 0 is not in the dispatch table”

Mon, 18 Nov 2019 11:25:24 -0800 

Lucas_Werkmeister_WMDE added a comment.


  `0` is the argument to `lockClient()`, which is called in `selectClient()` 
wth keys of `$candidates`:
  
    $candidates = $this->getCandidateClients();
    
    while ( $candidates ) {
        // pick one
        $k = call_user_func( $this->array_rand, $candidates );
        $wiki = $candidates[ $k ];
        unset( $candidates[$k] );
    
        // lock it
        $state = $this->lockClient( $wiki );
  
  In `getCandidateClients()`, the return value ultimately comes from 
`IDatabase::selectFieldValues()`, implying that we have some 
`wb_changes_dispatch` rows where the `chd_site` is actually `0`. I’m not sure 
if that’s correct.
  
  I haven’t found any recent changes in Wikibase that sound relevant. However, 
the MediaWiki core change “Have `Database::addQuotes()` pass through bare 
integers without quoting” <https://gerrit.wikimedia.org/r/551024> was merged 
very recently, and sounds like it //might// cause this issue, though I don’t 
yet see exactly how this would happen.

TASK DETAIL
  https://phabricator.wikimedia.org/T238575

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Lucas_Werkmeister_WMDE
Cc: Addshore, Aklapper, Lucas_Werkmeister_WMDE, Iflorez, darthmon_wmde, 
alaa_wmde, DannyS712, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, 
LawExplorer, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, 
Lydia_Pintscher, Mbch331

_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to