tstarling added a comment.
In T238575#5672789 <https://phabricator.wikimedia.org/T238575#5672789>, @Lucas_Werkmeister_WMDE wrote: > In `getCandidateClients()`, the return value ultimately comes from `IDatabase::selectFieldValues()`, implying that we have some `wb_changes_dispatch` rows where the `chd_site` is actually `0`. I’m not sure if that’s correct. It looks like there is such a row. From the debug log of the build you referenced: INSERT OR IGNORE INTO unittest_wb_changes_dispatch (chd_site,chd_db,chd_seen,chd_touched,chd_lock,chd_disabled) VALUES (0,'foowiki',0,'00000000000000',NULL,0) In the test: $coordinator->initState( [ 'foowiki' ] ); The parameter is supposed to be "an associative array mapping client wiki IDs to client wiki (logical) database names", so passing ['foowiki'] causes the wiki ID to be 0. I note that the test is running SQLite, is there a reason for doing that? I couldn't reproduce the error with SQLite locally, but I'm not sure what version was used in the test. The addQuotes() change causes an integer instead of a string to be inserted into chd_site. Then the SELECT is later done by comparing chd_site with a string: chd_site='0'. You can imagine SQLite getting confused about that. It would probably work to either cast $siteID to a string in initState(), or to have the test call initState() correctly in the first place, say $coordinator->initState( [ 'foowiki' => 'foowiki' ] ); TASK DETAIL https://phabricator.wikimedia.org/T238575 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: tstarling Cc: Anomie, tstarling, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
