Lucas_Werkmeister_WMDE added a comment.
I think we should add a string cast in `SqlChangeDispatchCoordinator` – regardless of what the database implementation does, we probably shouldn’t rely on type conversion here. (I’d like it even more if we could require strings and throw an error otherwise, but due to PHP’s automatic conversion of array keys pointed out in T238575#5675061 <https://phabricator.wikimedia.org/T238575#5675061>, that doesn’t seem realistic.) That said, reverting the change to `DatabaseSqlite` also sounds like a good idea to me, though I don’t fully understand the consequences it would have… but I certainly hope we have no code that actually makes use of SQLite’s dynamic type system? TASK DETAIL https://phabricator.wikimedia.org/T238575 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: hoo, WMDE-leszek, Anomie, tstarling, Addshore, Aklapper, Lucas_Werkmeister_WMDE, Hook696, Daryl-TTMG, RomaAmorRoma, 0010318400, E.S.A-Sheild, Iflorez, darthmon_wmde, alaa_wmde, Meekrab2012, joker88john, DannyS712, CucyNoiD, Nandana, NebulousIris, Gaboe420, Versusxo, Majesticalreaper22, Giuliamocci, Adrian1985, Cpaulf30, Lahi, Gq86, Af420, Darkminds3113, Bsandipan, Lordiis, GoranSMilovanovic, Adik2382, Th3d3v1ls, Ramalepe, Liugev6, QZanden, LawExplorer, WSH1906, Lewizho99, Maathavan, _jensen, rosalieper, Scott_WUaS, Jonas, Wikidata-bugs, aude, Lydia_Pintscher, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
