Catrope added a comment.
In T297381#7559573 <https://phabricator.wikimedia.org/T297381#7559573>, @Lucas_Werkmeister_WMDE wrote: > @Catrope would you consider adding this `module.exports=Vue;` assignment directly to the `vue.global(.prod).js` files shipped by MediaWiki? That would fix our problem here and also slightly simplify the ResourceLoader setup, at the cost of having to repeat this step each time we want to update the bundled Vue. It's a bit trickier than that, because `foreign-resources.yaml` currently has no mechanism to automate such a post-processing step, and if we did it manually, we'd 1) forget all the time and 2) break the integrity check, because the post-processed file would have a different sha-512 hash. We could build post-processing steps into `foreign-resources.yaml` (ideally not by mangling the files themselves, but by adding new files that are derived from the original ones), and that is probably the best long-term solution, but I uploaded a quick and dirty solution that I hope will work for now. Vue ships a CommonJS version that we can't use in RL (because it tries to load other NPM packages) but that should hopefully work the purposes of lib-version-check. Let me know if that works. TASK DETAIL https://phabricator.wikimedia.org/T297381 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Catrope Cc: Michael, Catrope, Lucas_Werkmeister_WMDE, 786, Suran38, Biggs657, Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana, Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude, Jdforrester-WMF, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
