Lucas_Werkmeister_WMDE added a comment.
Thanks, I didn’t realize these lib files were built automatically already
(though that’s a good thing in general, of course). Unfortunately, it doesn’t
look like the CJS build is working with `require-from-url` either:
counterexample
$ node_modules/.bin/lib-version-check
Error while requiring library from
https://gerrit.wikimedia.org/r/changes/mediawiki%2Fcore~745954/revisions/1/files/resources%2Flib%2Fvue%2Fvue.cjs.js/download:
Cannot find module 'estree-walker'
Require stack:
-
/var/www/html/wiki1/extensions/Wikibase/node_modules/require-from-url/6d6608a59d11df077ef47cdbc74c62ea/r/changes/mediawiki%2Fcore~745954/revisions/1/files/resources%2Flib%2Fvue%2Fvue.cjs.js/download
-
/var/www/html/wiki1/extensions/Wikibase/node_modules/require-from-url/sync.js
-
/var/www/html/wiki1/extensions/Wikibase/node_modules/@wmde/lib-version-check/index.js
I think we (Wikibase devs) should spend a bit more time considering how we
could make lib-version-check work with Vue 3 (spitballing: maybe it could be in
the browser tests? there we get the file from ResourceLoader anyways…), and if
it’s actually worth that investment to us; in the meantime, let’s finish
disabling the version check for now (i.e. merge the remaining Wikibase change
<https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/745538>), and
not consider this a blocker for the Vue 3 migration (including the migration
away from the compat build).
TASK DETAIL
https://phabricator.wikimedia.org/T297381
EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/
To: Lucas_Werkmeister_WMDE
Cc: Michael, Catrope, Lucas_Werkmeister_WMDE, 786, Suran38, Biggs657,
Invadibot, Lalamarie69, maantietaja, Juan90264, Alter-paule, Beast1978, Un1tY,
Akuckartz, Hook696, Kent7301, joker88john, DannyS712, CucyNoiD, Nandana,
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan,
GoranSMilovanovic, Mahir256, QZanden, LawExplorer, Lewizho99, Maathavan,
_jensen, rosalieper, Bodhisattwa, Scott_WUaS, Wikidata-bugs, aude,
Jdforrester-WMF, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
