cscott added a comment.
In any case, apart from my general griping, this is the actual issue: In T298509#7609799 <https://phabricator.wikimedia.org/T298509#7609799>, @cscott wrote: > I don't know how DonationInterface and Wikibase are using this hook, but Parsoid's use is pretty subtle and not obviously easily replaced: Parsoid is *both* a library *and* and extension, and we need to be able to squirrel away Parsoid's "standalone" tests (run by `composer test` without access to a MediaWiki instance) somewhere where core's default auto discovery of tests won't find it -- and similarly, we need to be able to write "extension" tests (which require access to a MediaWiki instance) in a way that the standard `composer test` won't find them. > > This is pretty easy to do if extension discovery is done with executable code (or at least a hook to executable code). It seems quite challenging if you're using static `phpunit.xml.dist` files. If you allowed extensions to declaratively customize the 'tests/phpunit' subpath, that would probably be sufficient. Parsoid's extension.json could specify that MediaWiki should run the tests in `extension/tests/phpunit` and that MediaWiki should ignore the tests in `tests/phpunit`. TASK DETAIL https://phabricator.wikimedia.org/T298509 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: cscott Cc: Krinkle, cscott, kostajh, Jdforrester-WMF, Aklapper, Invadibot, maantietaja, Akuckartz, darthmon_wmde, WDoranWMF, EvanProdromou, DannyS712, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Agabi10, Scott_WUaS, Pchelolo, XenoRyet, Izno, Jrf, Wikidata-bugs, aude, Dinoguy1000, ssastry, Arlolra, Addshore, Mbch331, Jay8g
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
