Lucas_Werkmeister_WMDE added a comment.
@Sarai-WMDE I could use some clarifications on Figma, sorry… - In Figma, the header has a vertical margin of 1.25em. In the app, it currently has `$dimension-layout-xsmall` (1rem), or `$dimension-layout-small` (1.5rem) above the tablet breakpoint. Which breakpoint does Figma correspond to? And should I hard-code the 1.25em (1.25rem?), or is there another variable I’m missing? - In Figma, the “find more mismatches” button has a vertical margin of 1.5em, which apparently doesn’t collapse with the header margin. In the app, it currently has no margin of its own, but its surrounding elements produce a margin of 1.5rem (header, above) and 1rem (description section heading, below) respectively. Do we want to increase that? - In Figma, the description section has a lower margin of 3em; in the app, it’s currently 2.5rem. Do we want to increase that? - In Figma, the mismatches form footer (with the “save reviews” button) has an upper margin of 1.5em and a lower margin of 3.5em; in the app, it currently has an upper margin of 1rem, a lower margin of 2.5rem, and additionally a minimum height of 5em. I assume we want to remove the min-height (it doesn’t collapse with the margin, and I see nothing corresponding to it in Figma), but do we want to increase the margins? Basically, a lot of the differences I can see in Figma seem to be adding more space, not saving it 😅 though it’s very possible that I’m missing or misunderstanding something. TASK DETAIL https://phabricator.wikimedia.org/T323678 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
