Lucas_Werkmeister_WMDE added a comment.
> I assume we want to remove the min-height (it doesn’t collapse with the margin, and I see nothing corresponding to it in Figma) Looks like the minimum height is there to ensure that there’s enough space for the message when the reviews are saved – the message can appear without changing the layout: F35824012: Screenshot from 2022-11-29 12-55-15.png <https://phabricator.wikimedia.org/F35824012> F35824013: Screenshot from 2022-11-29 12-55-13.png <https://phabricator.wikimedia.org/F35824013> And this seems to be important because the message of one set of mismatches disappears as soon as you submit the next set of mismatches (when reviewing mismatches of multiple items on one page), so I guess you don’t want the page to jump around in that case as the older message disappears… but maybe we can instead only reserve that space for messages that have been shown at some point (e.g. by setting old messages to `visibility: none` instead of removing them), not for all potential messages? TASK DETAIL https://phabricator.wikimedia.org/T323678 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Lucas_Werkmeister_WMDE Cc: Michael, Lucas_Werkmeister_WMDE, Lydia_Pintscher, Sarai-WMDE, Nikki, Aklapper, Astuthiodit_1, karapayneWMDE, Invadibot, maantietaja, Mattia_Capozzi_WMDE, ItamarWMDE, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
