Michael added a subscriber: Bene.
Michael added a comment.

  Just disabling the check would reintroduce T111346 
<https://phabricator.wikimedia.org/T111346> for the same reason it origially 
worked:
  
  > The hook got run because when editing a wiki page and focusing the
  > summary field before saving, the stashedit api gets called which
  > already parses the wikitext and puts it into the parser cache.
  > Because the api sets $wgTitle to Special:Badtitle/dummy_title_for_
  > API_calls_set_in_api.php we are technically on a special page and
  > thus the hook gets run.
  
  Quoted @Bene from T111346#1642128 
<https://phabricator.wikimedia.org/T111346#1642128>.
  
  So while T292203 <https://phabricator.wikimedia.org/T292203> did improve the 
situation, we need to do something smarter.
  Also, I note that just removing the `MW_API` check and thus reintroducing the 
bug, did //not// fail any tests. We should probably also fix that.

TASK DETAIL
  https://phabricator.wikimedia.org/T327062

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Michael
Cc: Bene, ItamarWMDE, HasanAkgun_WMDE, Lydia_Pintscher, Lectrician1, Michael, 
karapayneWMDE, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, Invadibot, 
maantietaja, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, 
QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, 
Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to