Michael added a comment.
The current logic is: "Add Labels iff `(!$this->isApiRequest()) && ($linkRenderer->isForComment() || $currentTitle->isSpecialPage())`" Dropping the check for the API Request doesn't work, because it introduces the bug: "Add Labels iff `$linkRenderer->isForComment() || $currentTitle->isSpecialPage()`" But maybe we could modify the logic in way that get's all that we want: "Add Labels iff `$linkRenderer->isForComment() || (!$this->isApiRequest() && $currentTitle->isSpecialPage())`" Curious if @Lucas_Werkmeister_WMDE has thoughts on this. For now, I'll think about how to add a regression test for T111346 <https://phabricator.wikimedia.org/T111346> as well as for the desired behavior of this task. TASK DETAIL https://phabricator.wikimedia.org/T327062 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Michael Cc: Bene, ItamarWMDE, HasanAkgun_WMDE, Lydia_Pintscher, Lectrician1, Michael, karapayneWMDE, Lucas_Werkmeister_WMDE, Aklapper, Astuthiodit_1, Invadibot, maantietaja, Akuckartz, Nandana, lucamauri, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
