Sarai-WMDE added a comment.
Moving the button under the specified breakpoint doesn't solve all the overlap issues. The full logo can still collide with a long text button above 608px. F37124534: Screenshot 2023-06-30 at 15.00.30.png <https://phabricator.wikimedia.org/F37124534> For that reason, we're exploring other potential solutions: - Basing the change of position of the button on the regard a minimum margin between the logo and the button: If said margin is going to be "surpassed", the button would move below the logo. The downside of this approach is that users might see the button move under the logo as a consequence of selecting a longer language. While this might be an edge case, it is really suboptimal. - Applying ellipsis to the Button when said minimum margin is surpassed. This is a convenient solution that, unfortunately, would involve applying changes to WiKit, something we agreed not to do given the deprecated status of that library. In case we found this solution convenient, we could always assume the current state (or apply a different solution) and wait to implement (in the long run) this as part of the Codex migration. Codex buttons do display ellipsis by default in lack of sufficient space, so we'd get that out-of-the-box. TASK DETAIL https://phabricator.wikimedia.org/T335596 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: noarave, Sarai-WMDE Cc: guergana.tzatchkova, Arian_Bozorg, Aklapper, karapayneWMDE, Michael, Lydia_Pintscher, ItamarWMDE, Lucas_Werkmeister_WMDE, Sarai-WMDE, Astuthiodit_1, Invadibot, maantietaja, Akuckartz, Nandana, Lahi, Gq86, GoranSMilovanovic, QZanden, LawExplorer, _jensen, rosalieper, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org
