Sarai-WMDE added a comment.

  In T335596#9002421 <https://phabricator.wikimedia.org/T335596#9002421>, 
@Michael wrote:
  
  > In T335596#8993038 <https://phabricator.wikimedia.org/T335596#8993038>, 
@Sarai-WMDE wrote:
  >
  >> Hello there! Thanks so much for the fixes. Looking at the latest changes 
in Netlify <https://934540--clicky-sparqly.netlify.app/>, there seems to be an 
issue: the Language selector becomes unusable if the button is wrapped above 
the mobile breakpoint. The Language Selector menu should always be displayed 
within the viewport:
  >>
  >> F37130412: Screenshot 2023-07-06 at 12.33.34.png 
<https://phabricator.wikimedia.org/F37130412>
  >
  > That, and at least for me, it also seems to not work correctly on languages 
that actually do flip the interface, like Hebrew: 
https://934540--clicky-sparqly.netlify.app/?uselang=he (Both on Firefox 116 and 
Chromium 114). Can you reproduce that?
  >
  > Though I'm unsure whether that was caused by the changes in context of this 
particular task.
  
  I can indeed reproduce the same issue for RTL languages now. This wasn't a 
problem before the changes were merged, I'd say. I remember checking production 
in depth during one of our conversations that took place previously to the 
changes.

TASK DETAIL
  https://phabricator.wikimedia.org/T335596

EMAIL PREFERENCES
  https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: noarave, Sarai-WMDE
Cc: guergana.tzatchkova, Arian_Bozorg, Aklapper, karapayneWMDE, Michael, 
Lydia_Pintscher, ItamarWMDE, Lucas_Werkmeister_WMDE, Sarai-WMDE, 
Isabelladantes1983, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 
Astuthiodit_1, 786, Biggs657, Invadibot, maantietaja, Juan90264, Alter-paule, 
Beast1978, Un1tY, Akuckartz, Hook696, Kent7301, joker88john, CucyNoiD, Nandana, 
Gaboe420, Giuliamocci, Cpaulf30, Lahi, Gq86, Af420, Bsandipan, 
GoranSMilovanovic, QZanden, LawExplorer, Lewizho99, Maathavan, _jensen, 
rosalieper, Neuronton, Scott_WUaS, Wikidata-bugs, aude, Mbch331
_______________________________________________
Wikidata-bugs mailing list -- wikidata-bugs@lists.wikimedia.org
To unsubscribe send an email to wikidata-bugs-le...@lists.wikimedia.org

Reply via email to