daniel added a comment. Quick update on my take on this: If DOMTestUtils::assertTagSimple() implements a subset of PHPUnit's assertTag(), and doesn't (contrary to my earlier understanding) invent yet another way to specify tag matches, I'm not //fundamentally// opposed to using it. However, I' still not very eager to go that way because:
- DOMTestUtils would be "born deprecated". We don't want to encourage more usages of it, we really want it to go away and be replaced with something better (based on CSS selectors, perhaps) - DOMTestUtils is currently copied around. It would make more sense to put assertTagSimple() into the phpunit-dom-assertions project, which has support for assertTag as a TODO. Or at least put it into MediaWikiTestCase. If we //urgently// need to migrate to a PHPUnit 5, I'd agree to using assertTagSimple() for now. But it seems that there are several more blockers to this, which gives us time to work on The Real Solution. Well, knowing how things go, nobody will until it's really urgent, but hey, that's life ;) PS: Is it correct that the code in DOMTestUtils was mainly copied from PHPUnit? If so, it needs to attribute Sebastian Bergman to be in compliance with the BSD license: //"Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer."// TASK DETAIL https://phabricator.wikimedia.org/T69122 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: daniel Cc: JanZerebecki, Ricordisamoa, gerritbot, Aklapper, Wikidata-bugs, Bene, Tobi_WMDE_SW, JeroenDeDauw, adrianheine, Lydia_Pintscher, daniel, aude _______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
