| jcrespo added a comment. |
However, there are potentially several dozen places where we call LoadBalancer::getConnection (we try not to hog the connection, but only get it from the LB when we need it - so we do that often). We'd have to somehow loop this parameter through to all the places where we get the connection. Or is it sufficient to specify the group on the first call? Will the LB return a connection that was created for a specific group, if later no group is specified in the call to getConnection?
I cannot say by heart, I will have to check. We may want to loop in performance team as they gave good tips last time we had an issue with connection handling and tumbnails. I really do not think this is a general problem in all of wikidata, just in a couple of scripts- some scripts keeps connected for 9 minutes, mostly idle- that is the main issue.
However, for what you say, you may want to refactor the connection handling (wikidata's, not mediawiki's) to a more abstract-factoy-likey, as role can be 'dump' now and 'wikidata-special-dump' tomorrow (that is not actually happening, but it could).
Cc: daniel, hoo, ArielGlenn, jcrespo, Zppix, D3r1ck01, Izno, Wikidata-bugs, aude, Mbch331
_______________________________________________ Wikidata-bugs mailing list Wikidata-bugs@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs
