Bawolff added a comment.

They're not fully redundant, since rc_type for Wikidata is RC_EXTERNAL (from core, thus not Wikidata-specific).

Afaict only wikidata uses it. Flow uses a different number. Personally i think it would have made more sense to stick with numbers and have each ext pick a unique one, but that ship has sailed...

The IN would at best be a range condition (although im not sure mariadb would see it that way because it cant tell its a contiguous range). Usually the range has to be the rightmost part of the index we're using, so i dont think that would work, as the idea is to segregate the table by putting the wikidata stuff by putting that at the leftmost part of the index. (It could maybe do index merge or we could manually UNION, but it seems like mariadb doesnt usually choose that path, and im not sure thats really ideal given how many rows the query already has to look at). I think perhaps an option here would be a virtual is wikidata column so it could be a binary condition and not a range, but itd have to be a wmf hack as mw min mysql version doesnt support virtual columns .


TASK DETAIL
https://phabricator.wikimedia.org/T171027

EMAIL PREFERENCES
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

To: Bawolff
Cc: Ankry, Ladsgroup, Lsanabria, Josve05a, Bawolff, greg, Dominicbm, Vriullop, Jmabel, Fae, IKhitron, Johan, Herzi.Pinki, jmatazzoni, Trizek-WMF, Mattflaschen-WMF, KTC, Framawiki, zhuyifei1999, Marostegui, aaron, Andrei_Stroe, Turbojet, Rsocol, Strainu, Jwh, Pyb, Darwinius, Arbnos, Jdforrester-WMF, TheDJ, gerritbot, VladXe, Kf8, Liuxinyu970226, Jay8g, TerraCodes, Iniquity, jcrespo, Reedy, Catrope, Vicpeters, Demidenko, MaxBioHazard, Aklapper, Waytogoeducation, GoranSMilovanovic, Abiyoyo, QZanden, Vali.matei, Jack_who_built_the_house, Minhnv-2809, Poyekhali, Volker_E, Izno, Wong128hk, Luke081515, Wikidata-bugs, Base, aude, GWicke, El_Grafo, Gryllida, putnik, Steinsplitter, Mbch331, Krenair
_______________________________________________
Wikidata-bugs mailing list
Wikidata-bugs@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikidata-bugs

Reply via email to