On Mon, Mar 1, 2010 at 13:35, Domas Mituzas <midom.li...@gmail.com> wrote: > Still, the decision to merge certain changes into MediaWiki codebase (e.g. > relative includes, rather than $IP-based absolute ones) would be quite > invasive. > Also, we'd have to enforce stricter policy on how some of the dynamic PHP > features are used.
I might be revealing my lack of knowledge about PHP here but why is that invasive and why do we use $IP in includes in the first place? I did some tests here: http://gist.github.com/310380 Which show that as long as you set_include_path() with $IP/includes/ at the front PHP will make exactly the same stat(), read() etc. calls with relative paths that it does with absolute paths. Maybe that's only on recent versions, I tested on php 5.2. _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l