On Tue, Nov 30, 2010 at 10:04 AM, Chad <innocentkil...@gmail.com> wrote:
> All changed/added files ending in .inc/.php/.php5 are now
> checked with php -l prior to the transaction completing. You
> should get a fun error message on your local console if you
> commit bad code :)

This assumes that all .inc files are actually PHP.  Probably they are
right now, but I can foresee this potentially breaking years down the
line and confusing someone.  Maybe for .inc files, you should check if
they start with "<?php" before trying php -l.

_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to