In JavaScriptDistiller,  inside of the createParser() function, we have:
$parser->add( '/\\/\\*(.|[\\r\\n])*?\\*\\//' );

It took me hours to track down that this was causing Apache 2.1.11 to crash
on nearly any page view on my test wiki. This happened when a large JS
bundle is loaded, such as:
load.php?debug=false&lang=en&modules=jquery.checkboxShiftClick|jquery.client|jquery.cookie|jquery.makeCollapsible|jquery.placeholder|mediawiki.action.watch.ajax|mediawiki.language|mediawiki.legacy.ajax|mediawiki.legacy.diff|mediawiki.legacy.mwsuggest|mediawiki.legacy.wikibits|mediawiki.util&skin=vector&version=20110129T005517Z

I made a simple php file to reproduce this. It crashes when viewed over
apache but not CLI. It appears to be http://bugs.php.net/bug.php?id=47689
(which uses a similar regex).

Is something worth adding a note somewhere about or tweaking some code?
-- 
View this message in context: 
http://old.nabble.com/ResourceLoader-%2B-Windows-%2B-PHP-bug-47689-tp30792236p30792236.html
Sent from the Wikipedia Developers mailing list archive at Nabble.com.


_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l

Reply via email to