User "Brion VIBBER" changed the status of MediaWiki.r87143. Old Status: new New Status: fixme
User "Brion VIBBER" also posted a comment on MediaWiki.r87143. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87143#c17836 Commit summary: Followup to r85907, correctly quote table names. Followup to r87129, add handling of arrayed GROUP BY/ORDER BY options to match core class so that this will indeed work. Comment: Rather than calling $db->tableName( $foo, false ) with an opaque parameter and then calling $db->addQuotes() explicitly... consider simply calling $db->tableName( $foo ) and not double-escaping it. :) This will make things simpler and less confusing for future maintainers. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
