User "Brion VIBBER" changed the status of MediaWiki.r87143. Old Status: fixme New Status: ok
User "Brion VIBBER" also posted a comment on MediaWiki.r87143. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87143#c17837 Commit summary: Followup to r85907, correctly quote table names. Followup to r87129, add handling of arrayed GROUP BY/ORDER BY options to match core class so that this will indeed work. Comment: Hmm.. actually it makes sense, as identifier and *string* escaping may be different here, and you're tossing them into queries. Proper thing to do is probably to have a clearer constant to use on the second parameter to tableName, as the 'false' is totally unclear. :) Marking OK with a todo. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
