User "^demon" posted a comment on MediaWiki.r82783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82783#c19258 Commit summary:
* (bug 24230) Added JAR detection. ZIP archives containing a .class file will be rejected by default. Malformed ZIP archives will be rejected due to the danger of ambiguous parsing on the client side. * Removed the ZIP subtypes from $wgMimeTypeBlacklist, they no longer need to be there. * Added ZipDirectoryReader. Added some small ZIP files which are used to test its various error cases. Most were constructed with a hex editor. * Fixed getStatusArray() to return a consistent type regardless of whether the error message has parameters. This allows error messages with no parameters to work with the Status object conversion code in UploadBase::verifyFile(). Comment: Is there a reason you didn't make ZipDirectoryReaderError extend MWException and Exception instead? From the looks of it the idea was to make it reusable like some of our code in /includes/libs/. The only thing I see preventing that is the use of Status objects and the one wfDebug() call. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
