User "Tim Starling" posted a comment on MediaWiki.r82783. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82783#c19293 Commit summary:
* (bug 24230) Added JAR detection. ZIP archives containing a .class file will be rejected by default. Malformed ZIP archives will be rejected due to the danger of ambiguous parsing on the client side. * Removed the ZIP subtypes from $wgMimeTypeBlacklist, they no longer need to be there. * Added ZipDirectoryReader. Added some small ZIP files which are used to test its various error cases. Most were constructed with a hex editor. * Fixed getStatusArray() to return a consistent type regardless of whether the error message has parameters. This allows error messages with no parameters to work with the Status object conversion code in UploadBase::verifyFile(). Comment: Maybe at an early stage of development, it was imagined as a standalone library. But it turns out that the PEAR ZIP library was not as bad as I thought it was, so it should be sufficient for most people who need a standalone library. So the main motivation for completing ZipDirectoryReader became the fact that it could be tuned for MediaWiki and integrated with it. _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
