User "Nikerabbit" posted a comment on MediaWiki.r95043. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95043#c21227 Commit summary:
line numbers and better style * new system to parse the diff, see parseLine() dispatcher. * show lines numbering for each chunk. * tweak style to replace the <pre> look'n feel, removing the first-child last-child selectors. * line numbers are not selected on mouse selection. Makes it easy to copy paste the patch. Note: old code left unchanged. To use it again, change the array_map callback in splitLines from 'parseLine' to 'colorLine'. Comment: 1) There seems to be consensus that protected should be the default value and that private/public should be used when necessary. 2) Ask Aryeh (Aryeh: can you write it down somewhere please, or point me to that?). It has to do with supporting xml parsers with certain document types that Mediawiki outputs (some of them don't define named entities at all). _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
