User "Krinkle" posted a comment on MediaWiki.r95043.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95043#c22061
Commit summary:

line numbers and better style

* new system to parse the diff, see parseLine() dispatcher.
* show lines numbering for each chunk.
* tweak style to replace the <pre> look'n feel, removing the first-child
  last-child selectors.
* line numbers are not selected on mouse selection. Makes it easy to
  copy paste the patch.

Note: old code left unchanged. To use it again, change the array_map
callback in splitLines from 'parseLine' to 'colorLine'.

Comment:

Yes, every single diff is unreadable because of this (it stops before the diff 
even starts).

Commenting out like the following is a temporary measure for our school wiki:
<pre>
        #       case '@': // r95043 CR –Krinkle
        #               $r = $this->handleChunkDelimiter( $line );
        #               break;
</pre>

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to