User "Brion VIBBER" posted a comment on MediaWiki.r100925.

Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100925#c25224
Commit summary:

new thumbnail behavior for thumbnailing with multi-file uploads.  Multi-file 
uploads don't get thumbnails, but have a control for
enabling them per-file in case they're needed.  Previous behavior is unchanged.
fixed a bug where filename warnings from the API would break FileAPI (chunked, 
multi-file) uploads.
Needs testing in older IE and firefox, but checking it in now so it can get 
started w/ review for deploy next week.

Comment:

Before you get too far into refactoring this, I also highly recommend merging 
common code with core's mediawiki.special.upload.js -- that code has for 
instance been updated to skip the base-64 data: URI step on browsers supporting 
window.createObjectURL() (which seems to be a bit faster, and also works around 
a hanging bug in Firefox 7 with some SVG files).

_______________________________________________
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview

Reply via email to