User "Brion VIBBER" posted a comment on MediaWiki.r100925. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100925#c25233 Commit summary:
new thumbnail behavior for thumbnailing with multi-file uploads. Multi-file uploads don't get thumbnails, but have a control for enabling them per-file in case they're needed. Previous behavior is unchanged. fixed a bug where filename warnings from the API would break FileAPI (chunked, multi-file) uploads. Needs testing in older IE and firefox, but checking it in now so it can get started w/ review for deploy next week. Comment: Yeah, the thumbnailing code should get hoisted out and used as a common module that's independent. (If you feel like really going whole-hog on it, another change should be made to discard the object URLs after they've been used to draw onto the scaled canvas. They auto-dispose when the page closes, but in UploadWizard we're potentially working with more files over some time, all in the same page.) _______________________________________________ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview