I disagree, the previous message would sound really bit offensive to
people who submitted the patch, and is nothing motivating for the
volunteers who spend their time trying to help with the project.
Imagine you send a code to open source project in a good faith and get
the reply: I'd be more happy if you didn't put your nose in our code,
because that's exactly how the previous message appeared to me.
On Fri, Mar 30, 2012 at 8:10 AM, Trevor Parscal <tpars...@wikimedia.org> wrote:
> No offense to those who have chimed in, but seriously, this is a silly
> discussion.
>
> Do we really have the bandwidth to be 15 messages deep on this thread?
>
> - Trevor
>
> On Thu, Mar 29, 2012 at 5:24 PM, Tim Starling <tstarl...@wikimedia.org>wrote:
>
>> On 29/03/12 00:10, Chad wrote:
>> > Hi everyone,
>> >
>> > There's been some comments that the phrasing for a -1 vote in
>> > Gerrit ("I'd prefer that you didn't submit this") is kind of personal
>> > and we can do better.
>> >
>> > I did some testing and this is totally configurable :) It won't change
>> > for old comments that were already submitted, but we can pick
>> > some nicer wording going forward.
>> >
>> > I really don't have any good suggestions for this, so I'm opening
>> > this up to the list for a bit of good old fashioned bikeshedding.
>>
>> I don't really want Gerrit putting words into my mouth regardless of
>> how nice they sound. There will always be cases where the phrase is
>> inappropriate and offputting, regardless of which one you choose.
>>
>> How about "Set code review score to -1"? Then a more personal message
>> can be typed by the human doing the review.
>>
>> -- Tim Starling
>>
>>
>> _______________________________________________
>> Wikitech-l mailing list
>> Wikitech-l@lists.wikimedia.org
>> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
>>
> _______________________________________________
> Wikitech-l mailing list
> Wikitech-l@lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/wikitech-l
_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
