On Feb 21, 2013, at 4:51 PM, bawolff <bawolff...@gmail.com> wrote: >> >> * Work to get bugfixes backported to 1.19. I don't have Gerrit >> rights to commit to the REL1_19 branch, but that will keep me from >> fixing "bugs" by fiat. > > I think we should give you such rights. > > --bawolff
Though it is probably obvious, just to point out (and to be corrected if I misunderstood): You wouldn't single-handedly fix bugs. The bug fix is first submitted in master (where submission and review happen by two different people where Mark could be the writer of a patch or the reviewer/merger, but never both). And in release branches (as far as I know) we only tolerate self-merges if the change is a cherry-pick of an already-merged change in master. If the change is e.g. a bug fix of something that occurred due to combination of backports in the release branch, it should be reviewed and written by two different people like any other change. And for others looking to help out in back porting fixes: One can submit a backport without merge access. It is the same process (cherry-pick to another branch, submit back to Gerrit with the same change id). Except that you'd ask for someone to approve the merge instead of self-merging right away. -- Krinkle _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
