On 03/08/2013 10:20 AM, Bartosz Dziewoński wrote:
On Fri, 08 Mar 2013 17:07:18 +0100, Antoine Musso <hashar+...@free.fr>
wrote:
I guess the whole idea of using GitHub is for public relation and to
attract new people. Then, if a developer is not willing to learn
Gerrit, its code is probably not worth the effort of us integrating
github/gerrit. That will just add some more poor quality code to your
review queues.
This a hundred times. I manage a few (small) open-source projects at
GitHub, and most of the patches I get are not even up to my standards
(and those are significantly lower than WMF's ones).
Submitting a patch to gerrit and even fixing it after code review is
not that hard. (Of course any more complicated operations like
rebasing do suck, but you hopefully won't be doing that with your
first patch.)
I strongly disagree with this. I also get some poor quality pull
requests to my projects on GitHub, but once in a while I get something good.
To be honest, if I hadn't worked at WMF I'd have never thought about
learning something as obscure as gerrit just to submit a small patch.
And I wouldn't assume that without knowing the project well anyone would
want to contribute something big.
My reasoning: people get involved in open source projects by starting
with a small contribution and if we don't make it easy for them, they
just won't try.
--
Juliusz
_______________________________________________
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
