Update: I did some more exploring and discovered that very long filenames can cause the bad filename issue. I've added a margin of error to our file length chooser algorithm: https://gerrit.wikimedia.org/r/#/c/70223/
Whilst there I also added protection against uploading of bad file types, filenames with double apostrophes and better logging for bad filenames. I suspect these changes will drastically cut the upload error rate on mobile web. On Mon, Jun 24, 2013 at 11:18 AM, Arthur Richards <aricha...@wikimedia.org> wrote: > Nice work! Resolving the bad filename issue should get us down to a much > more acceptable error rate. > > > On Fri, Jun 21, 2013 at 3:19 PM, Jon Robson <jdlrob...@gmail.com> wrote: >> >> Update on error numbers: >> >> 111 errors since we pushed the fix on Tuesday 2pm to avoid anonymous token >> problems. >> >> Things are looking much better and come under 3 types of error >> Here is the new breakdown >> >> 1) Errors due to bad filenames / bad filetypes >> >> Missing filename: Bad filename 67 >> > This is now the biggest cause of errors. I suggest we log the file names >> > users are trying to upload with to identify what is going wrong. A bug is >> > open https://bugzilla.wikimedia.org/show_bug.cgi?id=49544 >> >> There are various other errors which are probably not worth our time as >> they suggest vandal edits: >> >> This file did not pass file verification 4 >> Unknown error: "titleblacklist-forbidden-edit" 5 >> Unknown error: "titleblacklist-custom-filename" 1 >> Missing filename: Filename exists 1 >> Missing filename: Duplicate archive 1 >> Filetype not permitted: MOV 1 >> > The file type not permitted errors could be solved by checking the image >> > in preview mode correctly loaded and whether it has a width that isn't 0. >> >> 2) Errors due to tokens >> >> >> Bad token name. 15 >> > These have all occurred on en.m.wikipedia.org, ru.m.wikipedia.org and >> > meta.m.wikimedia.org >> > 5 of them were on the uploads page >> Investigating with Chris it seems this can happen when a user has logged >> in on mobile, left the page for some time and thus their login has expired. >> Requesting a central auth token without being logged in will cause this >> error. We should explore checking login status before starting the upload >> workflow and redirect the user to the login page. >> >> Invalid token 5 >> > We are caching tokens that have since expired. We should explore >> > invalidating tokens. >> >> 3) Other errors >> These bugs are all pretty mysterious and it's not clear what causes them >> >> * The modification you tried to make was aborted by an extension hook 7 >> * error: 3 >> > Note This occurs when an error happens but the error is missing an >> > 'info' property. >> e.g. the response is: >> { error: {} } >> >> An internal error occurred 1 >> >> >> On Sat, Jun 8, 2013 at 3:49 PM, Max Semenik <maxsem.w...@gmail.com> wrote: >> > On 08.06.2013, 21:07 Brian wrote: >> > >> > >> >> I suspect that is caused by UploadBlacklist extension, which >> >> blacklists about 23 files by their sha hash. According to the config >> >> file, there's a log at "udp://$wmfUdp2logDest/upload-blacklist", so >> >> you can probably check if that guess is right. >> > >> > $ grep -v 'MISS' upload-blacklist.log >> > $ >> > >> > -- >> > Best regards, >> > Max Semenik ([[User:MaxSem]]) >> > >> > >> > _______________________________________________ >> > Wikitech-l mailing list >> > Wikitech-l@lists.wikimedia.org >> > https://lists.wikimedia.org/mailman/listinfo/wikitech-l >> >> -- >> Jon Robson >> http://jonrobson.me.uk >> @rakugojon >> >> >> _______________________________________________ >> Mobile-l mailing list >> mobil...@lists.wikimedia.org >> https://lists.wikimedia.org/mailman/listinfo/mobile-l >> > > > > -- > Arthur Richards > Software Engineer, Mobile > [[User:Awjrichards]] > IRC: awjr > +1-415-839-6885 x6687 -- Jon Robson http://jonrobson.me.uk @rakugojon _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
