Another point to look into if someones wants to refactor the RL debug=true: When loading VE with debug=true hundreds of modules are loaded (with different requests) and it takes long to load it. It would be nice to have an option of "debug=0.5" :) in which all the resources (or at least the ve resources) will be loaded as one request, but without minified code and including all the comment.
On Wed, Dec 11, 2013 at 8:46 PM, Jon Robson <jdlrob...@gmail.com> wrote: > +1000 to what Max says. It really is kinda obvious to anyone who needs to > know how to get into debug mode and if not there are wiki pages and if not > it's easy enough to find out if you care enough. > > That said debug mode could definitely be improved and I'm glad you brought > this topic up Max. A few things of the top of my head I'd like to see: > > * RTL working in debug mode > * The code in ResourceLoader really could do with a good refactor - there > are far too many different code paths and it would be good if we could > simplify this to get them as close as possible. When I've worked with RL in > the past to design my own modules which involves files I've had a lot of > headaches trying to get things to work in both debug mode and non-debug > mode (JavaScript templates [1] being one concrete example) - and even then > the result wasn't quite was I was hoping for in that debug mode uses > load.php urls to inject JavaScript before the file that needs it. > > [1] > > https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FMobileFrontend.git/1f3c57137afae1d0f8ac602b62dccc741893d670/includes%2Fmodules%2FMFResourceLoaderModule.php > On 11 Dec 2013 08:33, "Max Semenik" <maxsem.w...@gmail.com> wrote: > > > On 11.12.2013, 19:36 Brian wrote: > > > > >> > > >> As everybody else already said, less bandwidth is a good thing for > most > > >> people, obfuscation is OK when the source is available elsewhere, and > > >> debug=true is not hard for developers to find. > > >> > > > > > I'd actually disagree with the assertion that debug=true is easy to > > > find, particularly for people who aren't active developers. Some > > > random on the internet who just wants to see what our js looks like > > > (out of curiosity or whatever) is not going to be able to find > > > debug=true. > > > > If they look at the URL it will be pretty obvious because all of them > > have debug=false as first parameter. > > > > -- > > Best regards, > > Max Semenik ([[User:MaxSem]]) > > > > > > _______________________________________________ > > Wikitech-l mailing list > > Wikitech-l@lists.wikimedia.org > > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > _______________________________________________ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l > _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
