On Mar 9, 2014 4:15 AM, "Ryan Lane" <rlan...@gmail.com> wrote: > > On Sat, Mar 8, 2014 at 7:05 PM, Tyler Romeo <tylerro...@gmail.com> wrote: > > > On Sat, Mar 8, 2014 at 9:48 PM, Ryan Lane <rlan...@gmail.com> wrote: > > > > > Wikimedia uses deployment branches. Just because someone +2/merges into > > > master doesn't mean it immediately shows up on Wikimedia servers. It > > needs > > > to go into a deployment branch, then it needs to get deployed by a > > person. > > > Also, we use a gating model, so tests are required to pass before > > something > > > is merged. I believe there are some tests that are essential, but take > > too > > > long to run, so they aren't gating, but the situation isn't as dire as > > you > > > claim. > > > > > > > OK, then how did this change get deployed if it "broke" tests? > > > > > The jenkins report says it passed tests, hence why it was deployed. If > there's other tests that aren't reporting to gerrit or if there's a test > that needs to be added, maybe that's a post-mortem action to track? > > - Ryan
If the test infrastructure can't handle running every test on every commit (why can't they by the way, and could that be remedied?) Would it be possible and desireable to make sure a more elaborate test suite with all available tests in run as a gate before cutting the production branch? --Martijn > _______________________________________________ > Wikitech-l mailing list > Wikitech-l@lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/wikitech-l _______________________________________________ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
