On Fri, Jul 31, 2009 at 3:51 AM, Roderick Colenbrander<thunderbir...@gmail.com> wrote: > On Fri, Jul 31, 2009 at 9:25 AM, Austin English<austinengl...@gmail.com> > wrote: >> On Thu, Jul 23, 2009 at 3:51 PM, Roderick >> Colenbrander<thunderbir...@gmail.com> wrote: >>> Hi, >>> >>> For some weeks I have been working on moving more 2D rendering to >>> XRender. XRender has three advantages for Wine. First of all it allows >>> us to perform more rendering operations using X which we previously >>> did using a combination of software rendering and back-forth copying >>> between the Xserver. Second XRender offers depth conversion (this >>> gives us proper alpha support in Wine and allows us to bypass DIB >>> color conversion in some cases!). Third XRender brings us more >>> hardware acceleration and that way more performance. >>> >>> The patch attached to this thread adds support for dibsections in >>> additional color depths. On Xservers running at 24-bit this patch >>> offers us dibsections in 1-bit/15-bit/16-bit/24-bit/32-bit. (32-bit is >>> for proper alpha support) Big parts of the Wine X11 Driver make >>> assumptions about having only two color depths around (1-bit and >>> screen_depth e.g. 24-bit). I would like to request that people apply >>> the current patch to latest git (in combination with the Office2007 >>> patch which I posted to wine-patches). Please report any 2D rendering >>> issues you see and also mention possible Wine crashes due to X errors >>> like BadMatch. Try as much programs as possible. >>> >>> Thanks in advance, >>> Roderick Colenbrander >>> >>> >>> >>> >> >> Still fails the gimp test in appinstall. It's just this patch on top >> of git, nothing else right? >> >> -- >> -Austin >> > > Yeah it is just this patch on top of git. At what point does gimp fail > for you? I tried to open some images including the png gimp splash > screen and I'm seeing no issues. To be certain that you are using the > right patch I have reattached it (this time with the white space > trailing issues fixed). Just to be sure what display drivers are you > using and what videocard?
That one worked...perhaps I had some cruft in my tree :-/. This line is new in the output: (gimp-2.6.exe:52): Gimp-Display-CRITICAL **: gimp_display_shell_draw_get_scaled_image_size_for_scale: assertion `GIMP_IS_IMAGE (shell->display->image)' failed but doesn't seem to be critical. Card is a 9800 GeForce GTX, 190.18 drivers. Running the suite again, it seems to work fine. Photoshop had that failure we discussed on IRC, but it's a subtle race condition unrelated to your patch. I'm working on that now. -- -Austin