Sure. Having tests is better but in this case there is no chance for regression. I usually write tests for my personnal pursose or to compare behaviour against real windows or native dll. I don't think lack of tests in this case should prevent integration. Tests can be added later if needed. That said, if it is really a problem, I can add some basic ones. But I don't think so.
> Message du 22/02/10 13:06 > De : "Henri Verbeet" > A : wine-devel@winehq.org > Copie à : > Objet : Re: [PATCH 4/5] d3dx9_36: Implement D3DXFindShaderComment (based on > code from Luis Busquets) > > > I think tests would be appropriate. > > > >