Hi Henri 

>I mean that I don't think the "rotation" argument to
> GetAdapterDisplayMode() should be allowed to be NULL.

I tested IDirect3D9Ex::GetAdapterDisplayModeEx and that allows pRotation to be 
NULL, and still happily retrieves all  other (D3DDISPLAYMODEEX) info. So it's 
seems logical IWineD3DGetAdapterDisplayMode is allowed to have it's rotation 
parameter NULL as well.

I attached a new series of patches to the bug 
http://bugs.winehq.org/show_bug.cgi?id=18640 

>It probably also makes sense to properly start adding the required
> support from the bottom. XRandR should be able to retrieve the display
> rotation, but if that's not available you can just let winex11.drv
> return an identity rotation.

I fear i'm completely unfamiliar with XRandr; i think right now it's beyond the 
scope of this patch series, the patch series is really meant to (partly) tackle 
bug 18640 



      


Reply via email to