Michael Stefaniuc <mstef...@redhat.com> wrote: > > @@ -102,7 +104,7 @@ static HRESULT WINAPI > > BmpFrameDecode_QueryInterface(IWICBitmapFrameDecode *iface > > IsEqualIID(&IID_IWICBitmapSource, iid) || > > IsEqualIID(&IID_IWICBitmapFrameDecode, iid)) > > { > > - *ppv = iface; > > + *ppv = &This->IWICBitmapFrameDecode_iface; > > } > > else > > { > this part of the change is gratuitous. As long as there is only one > interface implementation in the object there is no need for impl_from_Foo().
That's for consistency with other places, so if/when a new interface is going to be added it's obvious for an implementror what to do. Thanks for the review. -- Dmitry.