ApacheHttpClientConnectionHandler: openConnection should be synchronized,
should be thread pool and support connection pooling
------------------------------------------------------------------------------------------------------------------------------
Key: WINK-364
URL: https://issues.apache.org/jira/browse/WINK-364
Project: Wink
Issue Type: Bug
Components: Client
Affects Versions: 1.1.4
Reporter: Seshu Pasam
Attachments: wink-client-apache-httpclient.diff
I found the following issues when using ApacheHttpClientConnectionHandler:
a.) openConnection() should be synchronized. It need not be synchronized if the
httpClient was passed in, but that is typically not the case
b.) ApacheHttpClientConnectionHandler should be thread safe and support
connection pooling
c.) Deprecated method usage
d.) Request not properly aborted when exceptions are thrown by
httpClient#execute()
I will attach a patch. Please review and apply the patch. Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira