[
https://issues.apache.org/jira/browse/WINK-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13242622#comment-13242622
]
Hudson commented on WINK-364:
-----------------------------
Integrated in Wink-Trunk-JDK1.5 #475 (See
[https://builds.apache.org/job/Wink-Trunk-JDK1.5/475/])
Apply the patch for https://issues.apache.org/jira/browse/WINK-364. Thanks,
Seshu. (Revision 1307529)
Result = SUCCESS
rfeng : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1307529
Files :
*
/incubator/wink/trunk/wink-client-apache-httpclient/src/main/java/org/apache/wink/client/ApacheHttpClientConfig.java
*
/incubator/wink/trunk/wink-client-apache-httpclient/src/main/java/org/apache/wink/client/internal/handlers/ApacheHttpClientConnectionHandler.java
> ApacheHttpClientConnectionHandler: openConnection should be synchronized,
> should be thread safe and support connection pooling
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: WINK-364
> URL: https://issues.apache.org/jira/browse/WINK-364
> Project: Wink
> Issue Type: Bug
> Components: Client
> Affects Versions: 1.1.4
> Reporter: Seshu Pasam
> Labels: patch
> Attachments: wink-client-apache-httpclient.diff
>
>
> I found the following issues when using ApacheHttpClientConnectionHandler:
> a.) openConnection() should be synchronized. It need not be synchronized if
> the httpClient was passed in, but that is typically not the case
> b.) ApacheHttpClientConnectionHandler should be thread safe and support
> connection pooling
> c.) Deprecated method usage
> d.) Request not properly aborted when exceptions are thrown by
> httpClient#execute()
> I will attach a patch. Please review and apply the patch. Thanks
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
