https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15713

--- Comment #5 from João Valverde <joao.valve...@tecnico.ulisboa.pt> ---
(In reply to Peter Wu from comment #3)
> (In reply to João Valverde from comment #1)
> > pkg-config is being correctly used to provide hints to the search procedure.
> > The ENABLE_STATIC CMake option currently just disables building shared
> > libraries.
> > 
> > I wouldn't object to this patch, if it helps. Seems to be what you want?
> > (untested).
> > 
> > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > index d182d43017..2402d3d92f 100644
> > --- a/CMakeLists.txt
> > +++ b/CMakeLists.txt
> > @@ -730,6 +730,9 @@ include(CheckCXXCompilerFlag)
> >  
> >  if(ENABLE_STATIC)
> >         set(BUILD_SHARED_LIBS 0)
> > +       if (UNIX)
> > +               set(CMAKE_FIND_LIBRARY_SUFFIXES ".a")
> > +       endif()
> >  else()
> >         set(BUILD_SHARED_LIBS 1)
> >  endif()
> 
> This is not the appropriate location for a fix, it changes "ENABLE_STATIC"
> from
> 
>  "build static libraries, link to any shared/static library"
> 
> to
> 
>  "build static libraries, link with static libraries only"

That's obvious. As I said, I don't object to changing ENABLE_STATIC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
             mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

Reply via email to