https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=15713
--- Comment #13 from Peter Wu <pe...@lekensteyn.nl> ---
Hi Fabrice, could you upload your patches to Gerrit? See
https://www.wireshark.org/docs/wsdg_html_chunked/ChSrcContribute.html#ChSrcUpload
(In reply to fontaine.fabrice from comment #10)
> Created attachment 17081 [details]
> USE_STATIC option patch
Suggestions:
- Change subject from "CMakeLists.txt: ..." to just "CMake: ..."
- move the "CMAKE_FIND_LIBRARY_SUFFIXES" up, right after the oss-fuzz entry.
Consider changing the oss-fuzz entry to use the new option since it better
reflects the requirement for oss-fuzz.
(In reply to fontaine.fabrice from comment #11)
> Created attachment 17082 [details]
> FindPCAP patch
We already have a cmake/modules/FindNL.cmake module, are you sure that this
patch is needed for that?
--
You are receiving this mail because:
You are watching all bug changes.
___________________________________________________________________________
Sent via: Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
