https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335
--- Comment #60 from Jaap Keuter <jaap.keu...@xs4all.nl> ---
(In reply to Balling from comment #59)
> /ui/text_import.c#L1049
> 'info->offset_type == OFFSET_DEC' is always true because offset_type is enum.
So, defensive programming is discouraged?
> epan/dissectors/packet-infiniband.c#L2782
> Copy paste *offset = local_offset; can be removed.
I assume this should instead update local_offset.
> epan/dissectors/packet-ip.c#L1556
> enum
I don't understand the suggestion.
> epan/dissectors/packet-ipdc.c#L739
> This is impossible because get_ipdc_pdu_len has return raw_len + 4; but
> raw_len
> is unsigned, thus it cannot be < 4.
Again, defensive programming is discouraged?
--
You are receiving this mail because:
You are watching all bug changes.
___________________________________________________________________________
Sent via: Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives: https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe
