https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=16335

--- Comment #63 from Martin Mathieson <martin.r.mathie...@googlemail.com> ---
(In reply to Alexis La Goutte from comment #61)
> @Balling, it is better to propose some patch on Gerrit
> 
> > /ui/text_import.c#L1049
> > 'info->offset_type == OFFSET_DEC' is always true because offset_type is 
> > enum.
> May be move to a switch(offset_type)

Yeah, I don't like the nested ternary thing.
But even with all of the enum members in the switch, I'd still want to
(defensively) add the default case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___________________________________________________________________________
Sent via:    Wireshark-bugs mailing list <wireshark-bugs@wireshark.org>
Archives:    https://www.wireshark.org/lists/wireshark-bugs
Unsubscribe: https://www.wireshark.org/mailman/options/wireshark-bugs
             mailto:wireshark-bugs-requ...@wireshark.org?subject=unsubscribe

Reply via email to