First thanks to the authors for inventing such an amazing C++ web framework.
When I looked at the code related to internal path in WApplication,
which involves only dozens of lines, I found there are quite a few
places that could use some clean up, so I'm wondering if the authors
could take some time to review the entire codebase, which would
definitely make it more solid.
For example, in WApplication:
(1) currentInternalPath_ is declared but never used
(2) std::min(path.length(), newInternalPath_.length()); // the
value-only statement does nothing
(3) i = fileStart; // i is no longer used so this assignment is a waste
(4)
if (!next.empty())
newInternalPath_ = common + next;
internalPathChanged.emit(common);
if (next.empty()) {
newInternalPath_ = path;
break;
}
I would write
internalPathChanged.emit(common);
if (!next.empty())
newInternalPath_ = common + next;
else {
newInternalPath_ = path;
break;
}
(5) loadRsh() appears to do nothing other than logging
Is rsh.js really needed?
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
witty-interest mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/witty-interest
