Hey Bin Tan, 2008/10/10 Bin Tan <[EMAIL PROTECTED]>: > First thanks to the authors for inventing such an amazing C++ web framework. > When I looked at the code related to internal path in WApplication, > which involves only dozens of lines, I found there are quite a few > places that could use some clean up, so I'm wondering if the authors > could take some time to review the entire codebase, which would > definitely make it more solid.
Agreed. It is a rather new development which in itself was quite a significant refactoring of old code. We didn't clean it up entirely, yet. > For example, in WApplication: > (1) currentInternalPath_ is declared but never used Okay. > (2) std::min(path.length(), newInternalPath_.length()); // the > value-only statement does nothing Oops. I must have been called away in the midst of finishing that line :-) > (3) i = fileStart; // i is no longer used so this assignment is a waste Both i and fileStart are being used during the loop ? > (5) loadRsh() appears to do nothing other than logging > Is rsh.js really needed? No, it is no longer needed since 2.2.0: all of the internal path JavaScript code is now integrated into skeleton/Wt.js. The documentation needs to be updated (but I would keep the logging). Also, since 2.2.0, the internal path API is well supported across all browsers, and not only Firefox and Internet Explorer. Thanks for your suggestions! Regards, koen ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ witty-interest mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/witty-interest
