Cool, one colon down... way too many more to go. <wink/> -----Original Message----- From: Neil Sleightholm [mailto:[email protected]] Sent: Friday, January 30, 2009 16:11 To: Windows Installer XML toolset developer mailing list Subject: Re: [WiX-devs] Heat change -indent
I built the code from CVS and it looks and works ok. Neil -----Original Message----- From: Rob Mensching [mailto:[email protected]] Sent: 30 January 2009 20:32 To: Windows Installer XML toolset developer mailing list Subject: Re: [WiX-devs] Heat change -indent Neil, I had to tweak the last bit of code a bit to work correctly. Can you look at it and make sure I went the right way (it was late by the time I was getting to this <smile/>). -----Original Message----- From: Neil Sleightholm [mailto:[email protected]] Sent: Tuesday, January 27, 2009 14:18 To: Windows Installer XML toolset developer mailing list Subject: Re: [WiX-devs] Heat change -indent Rob, Here are the patches, if these get too messy though the email system let me know I will email them to you as an attachment. The heat.cs patch isn't nice because heat doesn't have a proper command line parser like light. In fact if you give it unknown options it just ignores them. Is this something to sort out for 3.0 or should it wait for 3.5? This is the patch to the documentation: Index: src/chm/html/heat.htm =================================================================== RCS file: /cvsroot/wix/wix/src/chm/html/heat.htm,v retrieving revision 1.1 diff -u -p -r1.1 heat.htm --- src/chm/html/heat.htm 23 Jan 2009 10:40:16 -0000 1.1 +++ src/chm/html/heat.htm 27 Jan 2009 22:01:44 -0000 @@ -267,7 +267,7 @@ heat.exe [-?] harvestType <harvester <tr> <td valign="top"> - <p>-indent:<n></p> + <p>-indent <n></p> </td> <td> This is the patch for heat.cs: Index: src/heat/heat.cs =================================================================== RCS file: /cvsroot/wix/wix/src/heat/heat.cs,v retrieving revision 1.15 diff -u -p -r1.15 heat.cs --- src/heat/heat.cs 23 Jan 2009 10:40:17 -0000 1.15 +++ src/heat/heat.cs 27 Jan 2009 22:12:23 -0000 @@ -154,7 +154,7 @@ namespace Microsoft.Tools.WindowsInstall harvestOptions.Add("-v", new HeatCommandLineOption("-v", HeatStrings.HelpMessageVerbose)); harvestOptions.Add("-wx[N]", new HeatCommandLineOption("-wx[N]", HeatStrings.HelpMessageTreatWarningAsError)); harvestOptions.Add("-wxall", new HeatCommandLineOption("-wxall", HeatStrings.HelpMessageTreatAllWarningsAsErrors)); - harvestOptions.Add("-indent<N>", new HeatCommandLineOption("-indent<N>", HeatStrings.HelpMessageIndentation)); + harvestOptions.Add("-indent <N>", new HeatCommandLineOption("-indent <N>", HeatStrings.HelpMessageIndentation)); foreach (HeatCommandLineOption commandLineOption in harvestOptions.Values) { @@ -352,7 +352,7 @@ namespace Microsoft.Tools.WindowsInstall { try { - this.indent = Int32.Parse(parameter.Substring(6), CultureInfo.InvariantCulture); + this.indent = Int32.Parse(parameter.Substring(7), CultureInfo.InvariantCulture); } catch { Neil -----Original Message----- From: Rob Mensching [mailto:[email protected]] Sent: 27 January 2009 16:46 To: Windows Installer XML toolset developer mailing list Subject: Re: [WiX-devs] Heat change -indent If you send a change before Thursday evening (PST), I'll get it in (planning to get your other changes then as well). Otherwise, I'll try to reserve some time to make the change myself... but I'm randomized like you wouldn't believe so I'm a gamble for any given change. <smile/> -----Original Message----- From: Neil Sleightholm [mailto:[email protected]] Sent: Tuesday, January 27, 2009 08:28 To: Windows Installer XML toolset developer mailing list Subject: Re: [WiX-devs] Heat change -indent I agree, drop colon but use a space. Is this likely to go in this week? If so I'll revise the documentation and post a patch here. Neil -----Original Message----- From: Rob Mensching [mailto:[email protected]] Sent: 27 January 2009 16:04 To: Windows Installer XML toolset developer mailing list Subject: Re: [WiX-devs] Heat change -indent Yeah, it looks like there are a lot of things that have slipped in that are using a colon when I wasn't watching closely. I really dislike the colon syntax (since it can mess up tab completion so much). I also agree, that the lack of space in the current "-indent" is not very clear either. What if we move "-indent" to use a space separated thing and I'll continue to mull over the other colon syntax... maybe create the alternative syntaxes (-ice ICE01) and eventually deprecate the old syntax. Hmm, ick. I really dislike inconsistencies like this. -----Original Message----- From: Neil Sleightholm [mailto:[email protected]] Sent: Friday, January 23, 2009 15:21 To: Windows Installer XML toolset developer mailing list Subject: Re: [WiX-devs] Heat change -indent Before I posted I checked other code: light, -ice:, -sice:, -dcl: smoke, -ice: most code: -out option I think the space and colon are used commonly. Personally, ident4 v. indent:4 v. indent 4 - I prefer the colon, although I also like "-out filename"! Is there a standard for command line options in Windows applications? I found this: http://www.microsoft.com/technet/scriptcenter/topics/winpsh/cmdline_std. mspx in it it states that a parameter name and its arguments should be separated by a colon or whitespace; so that would mean "-indent[:| ]n" - does that sound like a good compromise? That would make the code: else if (parameter.StartsWith("indent", StringComparison.Ordinal)) { try { this.indent = Int32.Parse(parameter.Substring(7), CultureInfo.InvariantCulture); } Neil -----Original Message----- From: Rob Mensching [mailto:[email protected]] Sent: 23 January 2009 19:33 To: Windows Installer XML toolset developer mailing list Subject: Re: [WiX-devs] Heat change -indent Documentation is busted, oops. However, none of the standard heat arguments use a colon. The other things are extensions and are not part of heat. The colon was unusual compared to most of the other options. It doesn't help that light is confused (like -cultures <sigh/>). Colons have been issues due to tab completion and I've heard PowerShell integration (I don't actually use PowerShell so that's all secondhand). Those reasons are why we've avoided the colon for most cases and instead use spaces (or no space). Thoughts? (documentation definitely needs to be fixed if it stays this way). -----Original Message----- From: Neil Sleightholm [mailto:[email protected]] Sent: Friday, January 23, 2009 10:49 To: [email protected] Subject: [WiX-devs] Heat change -indent One of my Heat changes was implemented slightly differently to how I did it. I implemented -indent:<n> but it was implemented -indent<n>, the reason I included the colon was to match WiXCop and some of the other Heat options (e.g. -t, -template and -pog) plus I think it is more legible. (The Heat documentation was also written to include the colon so would need revising.) Please could the colon be put back? Thanks Neil Neil Sleightholm X2 Systems Limited [email protected] ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------ ------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ WiX-devs mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/wix-devs
