That's interesting - my custom actions are usually so specific in what they do is that I just let them be called anyway and let them figure out what changes need undoing. I suspect I had similar issues as the OP with the "Installed" condition, and perhaps didn't trust that a component-action condition would be the same during rollback as during install.
Phil Wilson -----Original Message----- From: Richard [mailto:[EMAIL PROTECTED] Sent: Monday, December 08, 2008 10:17 AM To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] is it possible for Installed to be set during rollback processing, e.g. rollback custom actions should always have at least a "Not Installed" not a "Installed" entry in their sequence condition? In article <[EMAIL PROTECTED]>, "Wilson, Phil" <[EMAIL PROTECTED]> writes: > I don't believe this should matter. By definition a rollback custom > action is sequenced before the custom action whose changes it will > revert, and it will g et called if the install rolls back later than > it. The Installed state of the p roduct seems irrelevant to me. The rule is that your rollback action should have exactly the same condition as the action it rolls back. Otherwise, the rollback could be scheduled to undo something that wasn't done. Therefore, if your action has Installed in its condition (say its an action that only runs on a patch or modify), then the rollback action should have Installed in its condition as well, so that it is executed to "undo" whenever its corresponding "do" action is executed. I wrote an ICE that used a naming convention for rollback actions that let you check that: 1) the rollback action was sequenced before its "do" action 2) the rollback action and the "do" action had the same condition This caught lots of authoring errors on implementing rollback actions. -- "The Direct3D Graphics Pipeline" -- DirectX 9 draft available for download <http://www.xmission.com/~legalize/book/download/index.html> Legalize Adulthood! <http://blogs.xmission.com/legalize/> ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada. The future of the web can't happen without you. Join us at MIX09 to help pave the way to the Next Web now. Learn more and register at http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/ _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
