Thank you Rob, and Richard, that fixed my issues. Regards,
Adam Langley Senior Developer Tel: +64 9 486 9010 alang...@winscribe.com www.winscribe.com -----Original Message----- From: Richard [mailto:legal...@xmission.com] Sent: Friday, 16 January 2009 10:55 a.m. To: General discussion for Windows Installer XML toolset. Subject: Re: [WiX-users] run custom action on rollback from failure to commit In article <de33023b477fe44eaa71983f5279f6ce50fc456...@na-exmsg-c102.redmond.corp.microsoft.com>, Rob Mensching <rob.mensch...@microsoft.com> writes: > That looks much closer. Your last statement isn't _quite_ correct. > The defe rred actions (rollback actions are deferred) are "scheduled" > in the first pass of the Windows Installer. That's when the condition > is evaluated and that's wh y the rollback action always (almost?) has > the same condition as the "forward" action. The actions are executed > during the "execution" second pass and if the y weren't scheduled they > don't exist. When I first started supporting rollback on my custom actions, I concluded that you *always* want the rollback custom action to have the same condition as the custom action. Otherwise, there's a chance you could get one and not both. They always go together. Also, you need to make sure that the rollback custom action is always sequenced before the custom action it rolls back. Why? Because otherwise, you could have the custom action run without its rollback action being available. To enforce this relationship, we adopted a naming convention for custom actions like VendorXXX and for rollback custom actions VendorXXXRollback. Then I wrote an ICE that checked that the conditions between VendorXXX and VendorXXXRollback were consistent and that VendorXXXRollback was sequenced before VendorXXX. (We used a prefix that represented our company name, but I'm using the generic text 'Vendor' here, but you get the idea.) -- "The Direct3D Graphics Pipeline" -- DirectX 9 draft available for download <http://www.xmission.com/~legalize/book/download/index.html> Legalize Adulthood! <http://blogs.xmission.com/legalize/> ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users
