Neil,

Thanks for your feedback. I think I'm ready to bite the bullet and go the 
"always do a major upgrade" way.

> I major upgrade can do a "remove everything and reinstall" it depends where 
> RemoveExistingProducts is scheduled. In my example it will remove everything 
> before installing the new stuff

I gave your code some more playing. And I've hit two issues:

- the condition for not upgrading a later version seems reversed.
- more important: nothing's uninstalled before the installation. I still end up 
with x entries for that installer.

The log says:

Action start 16:53:24: ValidateProductID.
Action ended 16:53:24: ValidateProductID. Return value 1.
Action start 16:53:24: CostInitialize.
Action ended 16:53:24: CostInitialize. Return value 1.
Action start 16:53:24: FileCost.
Action ended 16:53:24: FileCost. Return value 1.
Action start 16:53:24: CostFinalize.
Action ended 16:53:24: CostFinalize. Return value 1.
Action start 16:53:24: InstallValidate.
Action ended 16:53:24: InstallValidate. Return value 1.
Action start 16:53:24: RemoveExistingProducts.
Action ended 16:53:25: RemoveExistingProducts. Return value 0.

And I have the following Upgrade block:

     <Upgrade Id="$(var.UpgradeCode)">
       <UpgradeVersion Minimum="$(var.version)" IncludeMinimum="yes" 
OnlyDetect="yes" Property="NEWERVERSIONDETECTED" />
       <UpgradeVersion Minimum="0.0.0" Maximum="$(var.version)"
                       IncludeMinimum="yes" IncludeMaximum="no"
                       Property="OLDERVERSIONBEINGUPGRADED" />
     </Upgrade>

     <InstallExecuteSequence>
       <FindRelatedProducts Before="LaunchConditions" />
       <RemoveExistingProducts After="InstallValidate" />
     </InstallExecuteSequence>

I updated the version number between builds, but not the UpgradeCode. What's 
wrong with that?

Michael



> - there is more information here: 
> http://www.joyofsetup.com/2008/12/30/paying-for-upgrades/.
> Neil
> Neil Sleightholm
> X2 Systems Limited
> n...@x2systems.com <mailto:n...@x2systems.com>
>
> ________________________________
>
> From: Michael Herger [mailto:s...@herger.net]
> Sent: Tue 17/02/2009 09:53
> To: General discussion for Windows Installer XML toolset.
> Subject: Re: [WiX-users] Updating full package
>
>
>
> Hi Alexander,
>
> thanks for your feedback. Yes, my example is not very helpful... But I've 
> gone through so many version and tests - I don't know what to post. The 
> latest way I've been testing is Neil's 
> (http://neilsleightholm.blogspot.com/search/label/WiX). But in this case I'd 
> end up with X copies of the same add-on installed (due to the lack of product 
> Id). If I add my product Id, it wouldn't allow me to install a newer build on 
> top of the existing version.
>
> Please note that I don't want to do a major upgrade (as defined by MS), I 
> don't want to uninstall the previous version. I just want it to put 
> everything on top of the existing installation.
>
> Michael
>
>
> Am 16.02.2009, 19:59 Uhr, schrieb Alexander Shevchuk 
> <alexander.shevc...@microsoft.com>:
>
>> Hi Michael,
>>
>> Make sure you follow all required steps to make major upgrade work.  In your 
>> simplified code I see Version attribute hard coded to "0.0.0.0".  Also, you 
>> did not provide your <Upgrade> table and how you schedule 
>> <RemoveExistingProducts>.  It is not obvious from your code if you change 
>> Product/@Id with every build.
>>
>> Regards,
>>
>> Alex
>>
>>
>>
>> -----Original Message-----
>> From: Michael Herger [mailto:s...@herger.net]
>> Sent: Monday, February 16, 2009 7:00 AM
>> To: wix-users@lists.sourceforge.net
>> Subject: [WiX-users] Updating full package
>>
>> Hi!
>>
>> I'm working on a Windows Home Server add-in. This is not intended for 
>> production systems yet. We're publishing nightly builds and want users to be 
>> able to just install on top of what they had before.
>>
>> The problem I've encountered is that either the packages install as 
>> different applications, leaving a mess with daily installations (of which 
>> only one can be uninstalled), or that I can't install one file on top of the 
>> other without uninstalling the old version first. I've been following 
>> several postings, tutorials etc. (eg. 
>> http://blogs.technet.com/alexshev/archive/2008/02/15/from-msi-to-wix-part-8-major-upgrade.aspx),
>>  but to no avail.
>>
>> Here's my simplified code:
>>
>> <Wix xmlns="http://schemas.microsoft.com/wix/2006/wi";>
>>       <Product
>>               Name="MyApp for Windows Home Server"
>>               Id="xxxxxx-f914-11dd-87af-0800200c9a66"
>>               UpgradeCode="xxxxxxx-EBBC-11DD-BA2F-0800200C9A66"
>>               Manufacturer="Me"
>>               Version="0.0.0.0"
>>               Language="1033">
>>
>>               <Package
>>                       Manufacturer="Me"
>>                       InstallerVersion="200"
>>                       Languages="1033"
>>                       Compressed="yes"
>>                       Id="*"
>>               />
>>
>>               <Media Id="1" Cabinet="MyApp_0.0.0.0.cab" EmbedCab="yes" />
>>
>>               <Property Id="WHSLogo">1</Property>
>>
>>               <Directory Id="TARGETDIR" Name="SourceDir">
>>                       <Directory Id="ProgramFilesFolder">
>>                               <Directory Id="WHS" Name="Windows Home Server">
>>                                       <Component
>>                                               
>> Id="HomeServerConsoleTab.MyPanel"
>>                                               
>> Guid="xxxxxx-f77a-11dd-87af-0800200c9a66">
>>
>>                                               <File
>>                                                       
>> Id="HomeServerConsoleTab.MyPanel.dll"
>>                                                       
>> Name="HomeServerConsoleTab.MyPanel.dll"
>>                                                       
>> Source="HomeServerConsoleTab.MyPanel.dll"
>>                                                       Vital="yes"
>>                                                       KeyPath="yes"
>>                                                       DiskId="1"/>
>>                                       </Component>
>>                               </Directory>
>>                       </Directory>
>>               </Directory>
>>
>>               <Feature Id="ProductFeature" Title="MyPanel" Level="1" 
>> AllowAdvertise="no">
>>                       <ComponentRef Id="HomeServerConsoleTab.MyPanel" />
>>               </Feature>
>>
>>       </Product>
>>
>> </Wix>
>>
>> Any help is greatly appreciated. Regards,
>>
>
>
>
> --
>
> Michael
>
> ------------------------------------------------------------------------------
> Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
> -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
> -Strategies to boost innovation and cut costs with open source participation
> -Receive a $600 discount off the registration fee with the source code: SFAD
> http://p.sf.net/sfu/XcvMzF8H
> _______________________________________________
> WiX-users mailing list
> WiX-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/wix-users
>
>



-- 

Michael

------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
WiX-users mailing list
WiX-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wix-users

Reply via email to